Skip to content

Fix NHC downing nodes due to /efi being mounted twice #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Fix NHC downing nodes due to /efi being mounted twice #719

merged 1 commit into from
Jun 25, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jun 25, 2025 •
edited
Loading

/efi is mounted both directly and via systemd-1 autofs. NHC logic can't cope with this and assumes that this means the mount is broken and drains the node.

This PR fixes this by filtering out /efi mountpoints. This is the only mountpoint with this problem.

NB:

  • CI will NOT succeed in this PR because the problem is in the previous release. Local checks on RL9 have shown the expected config.
  • No image build is required as the NHC config template is not built into the image.

@sjpb sjpb marked this pull request as ready for review June 25, 2025 10:57
@sjpb sjpb requested a review from a team as a code owner June 25, 2025 10:57
@sjpb sjpb merged commit 933dcf4 into main Jun 25, 2025
0 of 2 checks passed
@sjpb sjpb deleted the fix/nhc-efi-mounts branch June 25, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteau priteau priteau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @priteau